Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix add a PK when the table's pk_is_handle is true (#18340) #18342

Merged
merged 2 commits into from
Jul 8, 2020
Merged

ddl: fix add a PK when the table's pk_is_handle is true (#18340) #18342

merged 2 commits into from
Jul 8, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18340 to release-3.0

What problem does this PR solve?

Issue Number: close #18333

Problem Summary:
We can't add a primary key when the table's pk_is_handle is true.

What is changed and how it works?

Proposal: xxx

What's Changed:
If the table's PKIsHandle is true, we can't add a primary key to this table.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix add a primary key when the table's pk_is_handle is true

@zimulala @ti-srebot
cherry pick pingcap#18340 to release-3.0
f519109 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels Jul 3, 2020
@ti-srebot ti-srebot added this to the v3.0.16 milestone Jul 3, 2020
@ti-srebot
Copy link
Contributor Author

@zimulala please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

@zimulala
Copy link
Contributor

zimulala commented Jul 3, 2020

PTAL @tangenta @bb7133

@bb7133
Copy link
Member

bb7133 commented Jul 3, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2020
@ti-srebot
Copy link
Contributor Author

@bb7133,Thanks for your review.

AilinKid
AilinKid reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 3, 2020
@ti-srebot
Copy link
Contributor Author

@AilinKid,Thanks for your review.

@qw4990 qw4990 modified the milestones: v3.0.16, v3.0.17 Jul 6, 2020
@bb7133
Copy link
Member

bb7133 commented Jul 8, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 8062359 into pingcap:release-3.0 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

Assignees

@zimulala zimulala

Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.17
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @zimulala @bb7133 @AilinKid @qw4990